Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search-overlay page #1815

Closed
wants to merge 8 commits into from
Closed

feat: search-overlay page #1815

wants to merge 8 commits into from

Conversation

federicoisepponfincons
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • added the search-overlay page

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): added page for specific search overlay usage

Does this introduce a breaking change?

  • Yes
  • No

Other information

@federicoisepponfincons federicoisepponfincons linked an issue Jun 15, 2023 that may be closed by this pull request
Create a page example for search overlay #1800
Closed
@github-actions github-actions bot temporarily deployed to preview-pr1815 June 15, 2023 14:05 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@kyubisation
Copy link
Contributor

I checked with @mcilurzo and he had the following feedback:

  • The content (less padding) is drawn across the entire width of Ultra + instead of just on the grid
  • Distance above to the input is not correct
  • Close button (In the input) is also displayed when the input is empty.
  • Close button (in the input) doesn't seem to work
  • Title "often searched" is missing
  • "Show all 13 results" button is missing
  • Striking, but I wouldn't correct it: The border thickness of the magnifying glass icon is thicker in Florian's designs (like in the header).

@github-actions github-actions bot temporarily deployed to preview-pr1815 July 5, 2023 08:48 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1815 July 7, 2023 09:39 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1815 July 10, 2023 09:05 Inactive
kyubisation
kyubisation approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Also approved by Florian
Thank you for your effort 😃

@kyubisation
Copy link
Contributor

@federicoisepponfincons Can this be merged?

@kyubisation
Copy link
Contributor

Pending discussion with @mcilurzo

@github-actions github-actions bot temporarily deployed to preview-pr1815 August 9, 2023 15:54 Inactive
@WalkingOS WalkingOS marked this pull request as ready for review August 22, 2023 10:57
@github-actions github-actions bot temporarily deployed to preview-pr1815 August 28, 2023 09:56 Inactive
jeripeierSBB
jeripeierSBB requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus styles for results and also for the input field are not correct / visible

@jeripeierSBB
Copy link
Contributor

I fixed the focus outline for the results

@jeripeierSBB jeripeierSBB marked this pull request as draft December 18, 2023 15:12
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@jeripeierSBB jeripeierSBB jeripeierSBB requested changes

Assignees
No one assigned
Labels
pr: blocked Pull request is blocked either for merging or reviewing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a page example for search overlay
4 participants
@federicoisepponfincons @codecov-commenter @kyubisation @jeripeierSBB